Duplicate registration of review source folder after deleting source folder #10

Closed
maybeec opened this Issue Nov 15, 2014 · 2 comments

Projects

None yet

1 participant

@maybeec
Member
maybeec commented Nov 15, 2014
  1. Delete Review source folder (also on disk)
  2. After a warning occurred, which states to select a new review source folder to stay functional, you will get two popups:
    1. you will get the choose review source folder wizard popup to select / import / create a new review source folder
    2. you will get (most often in background) a prompt, which ask you if you want to add a new review source folder as currently no one can be found.
  3. Now create a new review source folder in the first dialog and select it for further usage AND also choose the option to select a new review source folder in the second dialog and select the same review source folder you recently created.

You will get the following errorneous behavior:

  1. Add a new review
  2. Add a new comment
    --> The comment will be added once to the author file but will be duplicated in the comment summary view

Most obviously getting two different popups to select a new review source folder seems to be the faulty behavior and the duplication of comments thus is a transitive resulting bug.

@maybeec maybeec added the bug label Nov 15, 2014
@maybeec maybeec added this to the v0.9.1 milestone Nov 15, 2014
@maybeec maybeec self-assigned this Nov 15, 2014
@maybeec maybeec closed this Nov 15, 2014
@maybeec
Member
maybeec commented Nov 15, 2014

Under some conditions I observed duplicate addition of a new comment to the comment summary view. This needs further investigation

@maybeec maybeec reopened this Nov 15, 2014
@maybeec
Member
maybeec commented Nov 15, 2014

As far as I could shortly investigate here, this might be an parallel execution problem. Debugging this problem case will never result in the faulty behavior. Nevertheless, starting eclipse in non-debug mode you might get this duplication of comments in comment summary view sometimes... try often enough ;)

@maybeec maybeec added a commit that referenced this issue Nov 16, 2014
@maybeec maybeec #10: synchronization according to loop detection implemented in #1 fi…
…xed, which leads to multiple addition of the same comment to comment summary after creating new comments
c068914
@maybeec maybeec closed this Nov 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment