Ability to cleanup only closed comments #13

Closed
Kleeven81 opened this Issue Feb 26, 2015 · 8 comments

Projects

None yet

4 participants

@Kleeven81

We would like the ability to do a cleanup that only removes the closed comments. This way we can remove all closed review items and keep those that still need attention.

@maybeec maybeec added the enhancement label Feb 27, 2015
@maybeec maybeec added this to the v0.9.1 milestone Feb 27, 2015
@maybeec
Member
maybeec commented Feb 27, 2015

Interesting feature.
I (or at least we) will have a look at this soon.

@postmann
Member

@Kleeven81: Thanks a lot for your interest in AgileReview and your feedback. Searching for comments with status "closed" is already possible. You can then simply remove them by selecting all comments and clicking the remove button in the Comments Summary View. Does this option suffice your needs?

auswahl_001

Still, I thought about this feature request for a while. The current way to do this might not be the best one (regarding UX). I think extending the cleanup option might not be the best idea as well. I would really like to keep the cleanup a one-click option without too many options to select from. Instead, an option would be to extend the Comments Summary View a bit. This view already has the option to "only show open comments".
This is actually the inverse option of what Kleeven81 request. Adding an additional filter "only show closed comments" would allow users to select those comments that are in state closed with one click instead of having to filter for those comments.

@Kleeven81

This was what I used in the end. It is definitely usable. I was hoping for an easy one click alternative to make it easier/faster.

Maybe it can be helpful if users can override the standard cleanup option to only remove closed comments. That way only the users that want this behaviour can use it and others will still have the standard cleanup functionality.

As I'm just a single user requesting this, if you don't see any added value in this feature I'll just keep doing it the 'old' way.

@postmann
Member
postmann commented Mar 3, 2015

In our project, the needs of the many do not outweight the needs of the few (if their feature requests are reasonable) ;)

I'll check what it would take to extend the cleanup option and will come up with some proposal.

@postmann postmann self-assigned this Mar 18, 2015
@postmann
Member
postmann commented Apr 3, 2015

It's been a while since I promised a proposal but good things come to those who wait ;)

Here's my idea of an improved Cleanup Action. I moved the configuration options to the preferences page instead of asking the user each time whether he wants to keep the comments. In addition, I created a new option to ignore open comments.
preferences

Now, during cleanup the user is asked if he really wants to perform the cleanup and is informed about the current configuration.
cleanup_dialog

@Kleeven81: does this suit your needs? Its not available via the development update site yet, but I think the screenshots give a good impression of the modifications I made.

@postmann postmann closed this Apr 3, 2015
@postmann postmann reopened this Apr 3, 2015
@Kleeven81

That looks like it will suit our needs perfectly!

@postmann
Member

Approved by user and fellow developers. Closing. Will be merged into development branch soon.

@postmann postmann closed this Apr 10, 2015
@postmann postmann added a commit that referenced this issue Apr 16, 2015
@postmann postmann Merge branch '#13-cleanup_extension' into next_Release
Conflicts:
	AgileReview/src/de/tukl/cs/softech/agilereview/dataaccess/ReviewAccess.java
	AgileReview/src/de/tukl/cs/softech/agilereview/views/commenttable/CommentTableView.java
609f9ac
@thebold
thebold commented Apr 18, 2015

This ability was only solved for the project cleanup and not for the cleanup in the review explorer. The same functionality should also existing in the review explorer.

@thebold thebold reopened this Apr 18, 2015
@postmann postmann added a commit that referenced this issue Apr 18, 2015
@postmann postmann #13: merge cleanup functionality of review explorer with extened cleanup
functionality of package explorer
dcac971
@postmann postmann added a commit that referenced this issue Apr 18, 2015
@postmann postmann #13: first reload views, the reparse editors as otherwise the parser …
…might try to parse for comments that are already disconnected from the tree
aec54ee
@maybeec maybeec closed this Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment