adjusting subscription <-> user relation to has_many to better reflect reality #2039
…tory girl based and not finished ...
…w an error if failed, and weird race condition
… premium mob stripe upgrade creates new subscription rather than overwriting previous one
mattwr18 pushed a commit that referenced this pull request
Jan 28, 2019
…t reality (#2039) * first step with various fails * added current_subscription method, which works, but tests are now factory girl based and not finished ... * updates user to avoid any use of old subscription method and prefer current_subscription * adjust service test to check we add subscriptions on top of old ones * fixing a step that was missing teeth, making saving subscription throw an error if failed, and weird race condition * ensure previous subscriptions are ended when new ones start, and that premium mob stripe upgrade creates new subscription rather than overwriting previous one * clean up spec * running down a time comparison issue * clean up and fix migration bug
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.