Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsnap should exit quietly upon command pipe EOF #4103

Open
warner opened this issue Nov 19, 2021 · 0 comments
Open

xsnap should exit quietly upon command pipe EOF #4103

warner opened this issue Nov 19, 2021 · 0 comments
Labels
enhancement New feature or request SwingSet package: SwingSet xsnap the XS execution tool

Comments

@warner
Copy link
Member

warner commented Nov 19, 2021

What is the Problem Being Solved?

@mhofman and I were examining some logs of the load generator, and noticed that when the kernel is shut down (SIGTERM to the kernel process), stderr is immediately filled with a bunch of error messages from the xsnap worker processes, with lines like:

Cannot read netstring, reading length prefix, fscanf

I think this is the netstring reader in the worker, which gets an end-of-file indication rather than a netstring length prefix header.

I'm thinking that the worker process should silently exit when it sees this happen, instead of complaining. Having the parent process exit is a perfectly reasonable time for the worker process to exit: it's the least exceptional form of shutdown we've got.

@warner warner added enhancement New feature or request SwingSet package: SwingSet xsnap the XS execution tool labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet xsnap the XS execution tool
Projects
None yet
Development

No branches or pull requests

2 participants