-
Notifications
You must be signed in to change notification settings - Fork 253
Adding some comments documenting captp.js. #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also I don't know anything about Agoric's style guide (or contemporary Javascript style at all) so sorry for the failing linting tests :) |
|
BTW, an additional thing to possibly comment, once understood: Are we right? :) |
Probably! :) BTW, your comments are welcome. You can look at the current CapTP as me trying to read and understand the Cap'n'Proto implementation and the liveSlots.js implementation, but not as well-documented. |
michaelfig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes. Thanks for this!
|
Updated. Thank you! (I don't completely understand why the directionality is introduced however... my read on the imports/exports and questions/answers per reading the original captp documentation is that the imports/exports end up being "specified" by the exporter and that questions/answers are "specified" by the questioner, and this is relevant to the way that collaborative GC ends up happening. But maybe I've misunderstood something... anyway, not critical to getting this PR in.) |
(First pass: there are some unanswered questions in the comments and some things are probably wrong!)
- Make "prettier" linter happier by removing pretty comment-alignment - Add @michaelfig's explaination for inversion - Removing question asking whether or not my comment was right (it apparently was)
First pass: there are some unanswered questions in the comments and some things are probably wrong!
I'd love review about how much I understand this... and I figured, while I'm trying to figure it out, maybe my attempt-at-understanding is generally useful for the module.
There are some questions (marked with
???) amongst the comments and some things are probably flat-out wrong, so review is encouraged before merging.I'm happy to make some changes if you are willing to review... or if you'd prefer to just modify and pull in yourself, that's welcome too.