-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New first contract #22
Conversation
- Explain Jessie | ||
``` | ||
|
||
Replace the content of `lib/ag-solo/vats/vat-pixel.js` with the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note that we're doing this to save a bunch of configuration work that isn't relevant to this exercise. Promise to document the proper way to install a new contract later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems worth adding to our documentation as a really quick intro to using the contract host.
…hings will improve
I added warnings about tutorial steps being hard sometimes If that's find with you as is, you can merge the PR I'm creating an issue label called Contract developer experience. It will be used to track anything that is lived as annoying by contract devs. Issues with this label probably will link to follow-up issues in other repos |
I don't mind committing to continuing to work to make things better, since that's what we plan to do. I don't like the phrasing "the steps in this tutorial may seem unnecessarily complicated". The work-around I pointed at is actually simpler than the right way to do things, so it's overly simplified. I think this would be better covered by an annotation at the point that we tell them to overwrite a file, saying that this is a hack that saves them work, and that better solutions are being developed. (As you've noted, they may even be in place quite soon, but they're certainly not ready now.) |
Closed in favor of #23 |
This is a different take of the first contract where less of the ERTP choregraphy happens in the code and more happens on the client-side
I kept things minimalist as far as explaining ERTP itself and delegate it to the ERTP dedicated documentation