New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Russian translation #185

Merged
merged 5 commits into from Feb 4, 2019

Conversation

Projects
None yet
5 participants
@MarshalX
Copy link
Contributor

MarshalX commented Jan 30, 2019

No description provided.

@MiniDigger

This comment has been minimized.

Copy link
Contributor

MiniDigger commented Jan 31, 2019

Can another Russian speaker confirm that this is actually better? Maybe @osipxd as he's the original author of the Russian translation.
It's really hard to review translations for a language you don't speak and even google has trouble with....

@DarkKeks

This comment has been minimized.

Copy link

DarkKeks commented Feb 1, 2019

I can confirm, that improved translation is actually better.
Also some typos are corrected:
Испоьзованиe -> Использование
игрка -> игрока

@osipxd
Copy link
Contributor

osipxd left a comment

ИМХО, добавление "Пожалуйста" в начало сообщений излишне.

Show resolved Hide resolved languages/core/acf-core_ru.properties Outdated
Show resolved Hide resolved languages/minecraft/acf-minecraft_ru.properties Outdated
Show resolved Hide resolved languages/minecraft/acf-minecraft_ru.properties Outdated
Update languages/minecraft/acf-minecraft_ru.properties
Co-Authored-By: MarshalX <marshal@xaker.ru>
@aikar

This comment has been minimized.

Copy link
Owner

aikar commented Feb 2, 2019

It appears there was discussion on it, are the discussions now resolved?

@MarshalX

This comment has been minimized.

Copy link
Contributor Author

MarshalX commented Feb 2, 2019

It appears there was discussion on it, are the discussions now resolved?

We are still discussing

Update languages/minecraft/acf-minecraft_ru.properties
Co-Authored-By: MarshalX <marshal@xaker.ru>

osipxd and others added some commits Feb 3, 2019

Update languages/core/acf-core_ru.properties
Co-Authored-By: MarshalX <marshal@xaker.ru>
Update languages/core/acf-core_ru.properties
Co-Authored-By: MarshalX <marshal@xaker.ru>
@MarshalX

This comment has been minimized.

Copy link
Contributor Author

MarshalX commented Feb 3, 2019

@aikar, discussion resolved)

@aikar aikar merged commit adf5de4 into aikar:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment