Upgrading to Storm 0.9.0.1 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modified get_storm_version to deal with 4 digit versions for storm * Updated URL for to apache incubator-storm project (no more nathanmarz) * Using thrift 0.9.1 (since it is the only one which compiles on OS X 10.9) * Removed 0.7.4 version in pom.xml to use 0.9.0 version for storm now
… it fails miserably... Recommending OS X users to pass along the virtualenv dir to petrel via the --venv arg.
|
From a quick review, the changes look good. I will review and test them soon. Sorry for slow reply -- my notification email in github.com was set incorrectly. |
|
@barrywhart no problem. FYI tested deployment to a small storm cluster with this set of patches and it worked properly. Thanks! |
barrywhart
added a commit
that referenced
this pull request
Jan 22, 2014
* More robust way of getting the Storm version * On Mac OS, skip code that creates a new virtualenv * Get storm.thrift from apache/incubator-storm instead of nathanmarz/storm
|
I took most of the changes, specifically:
I omitted some formatting-only changes. I will now create a branch for the old version (0.8), then review the changes that are version specific (just pom.xml, I think). |
barrywhart
added a commit
that referenced
this pull request
Jan 22, 2014
|
Generated a new egg (petrel-0.9.0.0.1-py2.7.egg) and uploaded to pypi.python.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches attempts to upgrade the dependencies to work with the latest Storm stable release (0.9.0.1) along with being able to run on Mac OS X (tested on 10.9.x).
I also tested this patch with Anaconda Python scientific distribution (http://continuum.io/) via providing the --venv argument to petrel CLI.
Let me know if you have any questions or catch any issues with my proposed changes.