Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #34

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Add unit tests #34

merged 2 commits into from
Oct 6, 2020

Conversation

sbernard31
Copy link
Contributor

@sbernard31 sbernard31 commented Sep 18, 2020 •
edited
Loading

This need a massive refactoring to make code easily testable. (this aims to implements #29)
Current tests are just poc.

@sbernard31 sbernard31 marked this pull request as draft September 18, 2020 15:55
@sbernard31 sbernard31 marked this pull request as ready for review October 2, 2020 16:02
@sbernard31 sbernard31 mentioned this pull request Oct 5, 2020
Closed
@sbernard31
Copy link
Contributor Author

I think this is now in a reviewable state.

@sbernard31 sbernard31 merged commit 3b3eef2 into master Oct 6, 2020
@sbernard31 sbernard31 mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliwer oliwer oliwer approved these changes

@msangoi msangoi Awaiting requested review from msangoi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernard31 @oliwer