Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Configurable bar_height #4

Closed
Airblader opened this issue Dec 4, 2014 · 1 comment
Closed

Configurable bar_height #4

Airblader opened this issue Dec 4, 2014 · 1 comment
Labels
enhancement i3bar

Comments

@Airblader
Copy link
Owner

No description provided.

@Airblader
Copy link
Owner Author

Note that the workspace buttons should ideally still be squares.

@Airblader Airblader mentioned this issue Dec 6, 2014
Closed
@Airblader Airblader changed the title Make bar_height configurable [i3bar] Configurable bar_height Dec 17, 2014
@Airblader Airblader changed the title [i3bar] Configurable bar_height Configurable bar_height Dec 17, 2014
Airblader added a commit that referenced this issue Dec 24, 2014
@Airblader
#4: enable making the bar_height configurable by using it consistentl…
3ad2b4b 
…y and remove borders around workspace buttons
Airblader added a commit that referenced this issue Dec 24, 2014
@Airblader
#4: update readme
4a47f34
Airblader added a commit that referenced this issue Dec 24, 2014
@Airblader
#4: restore spacer between buttons
dd5c1d9
Airblader added a commit that referenced this issue Dec 24, 2014
@Airblader
#4: restore insets
73b88b5
Airblader added a commit that referenced this issue Dec 24, 2014
@Airblader
#4: readme
087e934
Airblader added a commit that referenced this issue Dec 24, 2014
@Airblader
#4: inset status blocks for consistency
64cc633
Airblader pushed a commit that referenced this issue Nov 20, 2016
@hwangcc23 @stapelberg
Fix memory leaks (#2560)
9108f32 
Fix memory leaks when executing 'i3 --moreversion'.

=================================================================
==14852==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 159 byte(s) in 1 object(s) allocated from:
    #0 0x7fea40855602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x4c4c4a in smalloc ../../i3/libi3/safewrappers.c:24
    #2 0x4c3aee in ipc_recv_message ../../i3/libi3/ipc_recv_message.c:61
    #3 0x44dc2e in display_running_version ../../i3/src/display_version.c:94
    #4 0x472947 in main ../../i3/src/main.c:269
    #5 0x7fea3d0c982f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

Direct leak of 39 byte(s) in 2 object(s) allocated from:
    #0 0x7fea40855602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fea3d11f7d7 in vasprintf (/lib/x86_64-linux-gnu/libc.so.6+0x767d7)

SUMMARY: AddressSanitizer: 198 byte(s) leaked in 3 allocation(s).
Airblader pushed a commit that referenced this issue Aug 20, 2017
@stapelberg
Bugfix: check bounds before accessing memory
c25bee0 
This fixes the following issue when having an error early in the config file:

==1562==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6220000180ff at pc 0x55c837edb1d3 bp 0x7ffee7534650 sp 0x7ffee7534648
READ of size 1 at 0x6220000180ff thread T0
    #0 0x55c837edb1d2 in start_of_line ../../i3/src/config_parser.c:238
    #1 0x55c837edc96f in parse_config ../../i3/src/config_parser.c:493
    #2 0x55c837edf527 in parse_file ../../i3/src/config_parser.c:1091
    #3 0x55c837ecf14b in parse_configuration ../../i3/src/config.c:65
    #4 0x55c837ed1ef4 in load_configuration ../../i3/src/config.c:230
    #5 0x55c837f0a8d0 in main ../../i3/src/main.c:539
    #6 0x7fb63ae042b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
    #7 0x55c837e95eb9 in _start (/home/michael/i3/build/i3+0x4beb9)

0x6220000180ff is located 1 bytes to the left of 5165-byte region [0x622000018100,0x62200001952d)
allocated by thread T0 here:
    #0 0x7fb63e590cf8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1cf8)
    #1 0x55c837f59aa6 in smalloc ../../i3/libi3/safewrappers.c:24
    #2 0x55c837edef45 in parse_file ../../i3/src/config_parser.c:1029
    #3 0x55c837ecf14b in parse_configuration ../../i3/src/config.c:65
    #4 0x55c837ed1ef4 in load_configuration ../../i3/src/config.c:230
    #5 0x55c837f0a8d0 in main ../../i3/src/main.c:539
    #6 0x7fb63ae042b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
Airblader pushed a commit that referenced this issue Nov 10, 2018
@orestisfl
init_ws_for_output: use workspace_move_to_output
4d21f4c 
This fixes a crash produced with the following config:
    # i3 config file (v4)
    workspace 1 output $screen1
    workspace 2 output $screen2

    exec --no-startup-id "i3-msg workspace 1, open && i3-msg workspace 2 && xrandr --output $screen2 --off && xrandr --output $screen1 --auto --output $screen2 --auto --right-of $screen1 "

Which results in:
ERROR: AddressSanitizer: heap-use-after-free on address …
READ of size 8 at 0x614000001f48 thread T0
    #0 0x5563df6e73a8 in init_ws_for_output i3/src/randr.c:468
    #1 0x5563df6ef3b4 in randr_query_outputs i3/src/randr.c:940
    #2 0x5563df68dbe1 in handle_screen_change i3/src/handlers.c:450

… is located 264 bytes inside of 448-byte region …
freed by thread T0 here:
    #1 0x5563df634b0a in con_free i3/src/con.c:96
    #2 0x5563df7151e6 in tree_close_internal i3/src/tree.c:344
    #3 0x5563df7280fe in workspace_show i3/src/workspace.c:499
    #4 0x5563df6e7315 in init_ws_for_output i3/src/randr.c:457
    #5 0x5563df6ef3b4 in randr_query_outputs i3/src/randr.c:940
    #6 0x5563df68dbe1 in handle_screen_change i3/src/handlers.c:450

Which is similar to #3228, #3248.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement i3bar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Airblader