Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping and Spacing #438

Merged
merged 9 commits into from Jan 14, 2020
Merged

Grouping and Spacing #438

merged 9 commits into from Jan 14, 2020

Conversation

@spitsw
Copy link

spitsw commented Dec 9, 2019

Basic grouping and spacing.

The segment.stop is now calculated and adjusted based on segment.rawLength, segment.group and segment.spacing

Save and loading from EEPROM for segment[0].

I haven't updated the segments UI.

This is what I use for grouping LEDs for my Christmas lights.

I would like to see something that is feature compatible with this

@Aircoookie Aircoookie added this to the 0.9.1 milestone Dec 11, 2019
@Aircoookie

This comment has been minimized.

Copy link
Owner

Aircoookie commented Dec 11, 2019

Thank you, amazing work! Will do some minor adjustments and merge soon :)

@spitsw

This comment has been minimized.

Copy link
Author

spitsw commented Dec 11, 2019

@fhscholl

This comment has been minimized.

Copy link

fhscholl commented Dec 21, 2019

I think I'm reading this correctly, but I'm new to WLED so I want to be sure. Does this basically abstract pixels into groups and apply effects at the group level? Setting group size to 1 and spacing to 0 would result in the behavior today, but you could take a string of 192 lights with a group size of 12 and it would treat the whole string like it had 16 pixels?

If so, this is awesome and exactly what I need for a use case I started to design last week for my landscape lights.

@spitsw

This comment has been minimized.

Copy link
Author

spitsw commented Dec 22, 2019

@Aircoookie

This comment has been minimized.

Copy link
Owner

Aircoookie commented Jan 5, 2020

Fixed the merge conflicts. Will now make a few little changes and then merge, thanks :)

@spitsw

This comment has been minimized.

Copy link
Author

spitsw commented Jan 6, 2020

Note: I have observed an issue where the grouping/settings revert back to 1. I haven't had the time to investigate or fix.

The steps to reproduce are:

  • Set up a macro to turn on / off LED's.
  • Set up a daily timer to trigger on/off macros.

The LED's will turn on with a grouping of 1 on the 2nd day.

I don't think it's related to the macro's / timing, rather the segments aren't being initialised correctly in some circumstances. There is probably a quicker way to reproduce the problem.

Aircoookie added 4 commits Jan 14, 2020
@Aircoookie Aircoookie merged commit ae47c4c into Aircoookie:master Jan 14, 2020
1 of 2 checks passed
1 of 2 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.