Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new branch of IRremoteESP8266 to save 21k #582

Merged
merged 30 commits into from Jan 10, 2020

Conversation

@Def3nder
Copy link
Contributor

Def3nder commented Jan 10, 2020

Hi @Aircoookie , I did open an issue and talked with the author of the IRremoteESP8266 library.

He created a new branch "compile_flags" where the usage of the different modules can by selected at compile time with -D build flags.

So: no code changes at all - only platformio.ini changes that result in 21024 bytes smaller code 馃槃

Def3nder added 29 commits Nov 5, 2019
When adding an RGBW device to Alexa and then selecting a white color tone, Alexa will send CT values to the device. Having a warm white or cold white strip should use 100% of that strip and then add the RGB colors to get either a warmer color or a colder one.
Added IR remote with 40 keys to use with RGBW stripes.
...not implemented for ESP32 yet
ESP32 Solid RGBW defines

moved from env:esp32dev to env:esp32
ESP32 Solid RGBW defines
Update readme.md
To turn off IR remote use "0" in the settings, use 1 to 4 for different IR remote types.
adapt the logic to use CW and WW for different CT-values
Changed code from #define WLED_DISABLE_ANALOG_LEDS to #define WLED_USE_ANALOG_LEDS
NightLight used to brighten the light combined with fading from the actual (primary) color to the secondary color
RLYPIN definition dependant on WLED_USE_ANALOG_LEDS

Corrected list-item indents (readme.md)

updated to match upstream master (briLast in wled00.ino)
RLYPIN definition dependant on WLED_USE_ANALOG_LEDS

Fixed headline and corrected list-item indents (readme.md)

updated to match upstream master (briLast in wled00.ino)
...where the used functions can be controlled with -D build_flags.

This saves 21024 bytes of program space 馃槃
...where the used functions can be controlled with -D build_flags.

This saves 21024 bytes of program space 馃槃
changed to the new branch version

(this was the prove test with the old v2.7.2)
@Def3nder Def3nder force-pushed the Def3nder:IRremoteESP8266newBranch branch from fbaea16 to 13e84b0 Jan 10, 2020
@Aircoookie

This comment has been minimized.

Copy link
Owner

Aircoookie commented Jan 10, 2020

Awesome, thank you for sorting that out! :)

@Aircoookie Aircoookie merged commit a7a1002 into Aircoookie:master Jan 10, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
srg74 added a commit to srg74/WLED that referenced this pull request Jan 10, 2020
Include new branch of IRremoteESP8266 to save 21k (Aircoookie#582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.