Abdellatif Ait boudad aitboudad

Organizations

@symfony
aitboudad deleted branch translation_update_cmd at aitboudad/symfony
aitboudad commented on pull request symfony/symfony#14546
@aitboudad

@stof done and I also simplified getMessages see #14549

aitboudad opened pull request symfony/symfony#14549
@aitboudad
[Translation] simplify getMessages.
1 commit with 3 additions and 8 deletions
@aitboudad
  • @aitboudad 267cf79
    [Translator] deprecate getMessages in favor of getCatalogue.
aitboudad commented on pull request symfony/symfony#14530
@aitboudad

@stof see an initial work for DelegationLoader I'll complete it soon, I think we need to deprecate Symfony\Bundle\FrameworkBundle\Translation\Trans…

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

@stof FYI I work on delegating all the loading :)

aitboudad commented on pull request symfony/symfony#14544
@aitboudad

:+1: good catch !

aitboudad commented on pull request symfony/symfony#14523
@aitboudad

fixed thanks ^^

@aitboudad
@aitboudad
  • @aitboudad c3567f8
    [Translator] deprecate getMessages in favor of getCatalogue.
aitboudad commented on issue symfony/symfony#14529
@aitboudad

done #14546

aitboudad opened pull request symfony/symfony#14546
@aitboudad
[Translator] deprecate getMessages in favor of getCatalogue.
1 commit with 5 additions and 1 deletion
aitboudad commented on pull request symfony/symfony#14530
@aitboudad

well I think we need to keep getCatalogue and the optimize caching should be done by optimizing MessageCatalogue see #14526

aitboudad commented on issue symfony/symfony#14543
@aitboudad

changing the order of DecoratorServicePass solve the issue.

@aitboudad
[DI] use decorated service as parent doesn't work.
aitboudad commented on pull request symfony/symfony#14516
@aitboudad

This is meant to be a DX Initiative improvement. @javiereguiluz any thoughts? or should be closed ?

@aitboudad

:+1: @Tobion or moving config folder inside Resources ?

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

right

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

can you add this note above.

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

$this->getCatalogueInternal($bestLocale)

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

getDefinesLocale ?

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

TranslatorLocaleAwareInterface ?

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

same here

aitboudad commented on pull request symfony/symfony#14530
@aitboudad

it shoud be removed in 3.0 rename it into testLegacyPrimaryA.. instead and add $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);

aitboudad deleted branch translation_dep_msg at aitboudad/symfony
aitboudad commented on issue symfony/symfony#14529
@aitboudad

It was useful before adding getCatalogue until now I think we need to deprecate it.