Skip to content

Updated tp version 1.16 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 10, 2022
Merged

Updated tp version 1.16 #23

merged 5 commits into from
Nov 10, 2022

Conversation

@sandeep540
Copy link
Contributor

@sandeep540 sandeep540 commented Nov 10, 2022

About this change - What it does

Updated to Flink 1.16

Updated to Flink 1.16

Resolves: #22

Why this way

Updated Docker compose to refer local Dockerfile, rather than docker hub, also included flink kafka json jar

@sandeep540 sandeep540 requested a review from a team as a code owner November 10, 2022 05:40
snuyanzin
snuyanzin reviewed Nov 10, 2022
View reviewed changes
sql-client/Dockerfile Outdated
wget -P /opt/sql-client/lib/ https://jdbc.postgresql.org/download/postgresql-42.3.6.jar; \
wget -P /opt/sql-client/lib/ https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-avro-confluent-registry/1.15.0/flink-sql-avro-confluent-registry-1.15.0.jar; \
wget -P /opt/sql-client/lib/ https://github.com/knaufk/flink-faker/releases/download/v0.5.0/flink-faker-0.5.0.jar;
RUN wget -P /opt/sql-client/lib/ https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-elasticsearch7/1.16.0/flink-sql-connector-elasticsearch7-1.16.0.jar; \
Copy link
Contributor

@snuyanzin snuyanzin Nov 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN wget -P /opt/sql-client/lib/ https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-elasticsearch7/1.16.0/flink-sql-connector-elasticsearch7-1.16.0.jar; \
RUN wget -P /opt/sql-client/lib/ https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-elasticsearch7/3.0.0-1.16/flink-sql-connector-elasticsearch7-3.0.0-1.16.jar; \

Since 1.16.0 elasticsearch connector is externalized, IMHO it's better to use externalized version

Copy link
Contributor Author

@sandeep540 sandeep540 Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

snuyanzin
snuyanzin previously approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution
lgtm

@ftisiot
Copy link
Collaborator

ftisiot commented Nov 10, 2022 •
edited
Loading

Thanks @sandeep540!
I just checked by recreating the example at https://dev.to/ftisiot/build-a-streaming-sql-pipeline-with-apache-flink-and-apache-kafka-53jg

However when trying to select from a table built on top of Kafka, I get the following error

[ERROR] Could not execute SQL statement. Reason:
org.apache.flink.table.api.ValidationException: Could not find any factory for identifier 'kafka' that implements 'org.apache.flink.table.factories.DynamicTableFactory' in the classpath.

Available factory identifiers are:

blackhole
datagen
filesystem
print
python-input-format

The same with the 1.15 image works out of the box

ftisiot
ftisiot requested changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@ftisiot ftisiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small error in the Dockerfile was throwing an error

sql-client/Dockerfile Outdated
FROM flink:1.16.0-scala_2.12-java11

# Create CLI lib folder
COPY bin/* /opt/sql-client/
Copy link
Collaborator

@ftisiot ftisiot Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error I got was due to copying the sql client from the wrong path, this solves it

Suggested change
COPY bin/* /opt/sql-client/
COPY sql-client/bin/* /opt/sql-client/

@ftisiot
Copy link
Collaborator

ftisiot commented Nov 10, 2022

Could we also Update the README file with the correct version information?

ftisiot
ftisiot approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@ftisiot ftisiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! LGTM!

@ftisiot ftisiot merged commit 8158055 into Aiven-Open:main Nov 10, 2022
@sandeep540
Copy link
Contributor Author

sandeep540 commented Nov 10, 2022

@ftisiot Please update this as well - #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ftisiot ftisiot ftisiot approved these changes

+1 more reviewer

@snuyanzin snuyanzin snuyanzin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Flink 1.16

3 participants

@sandeep540 @ftisiot @snuyanzin