Skip to content

Special section "DEFAULT" #1

Merged
merged 4 commits into from Jul 23, 2011

2 participants

@pivaldi
pivaldi commented Jul 17, 2011

Special section "DEFAULT" sets default values for the other sections like Python does : http://docs.python.org/library/configparser.html

@Ajnasz
Owner
Ajnasz commented Jul 18, 2011

How would you deal when you save a configuration file.
With your current solution the default values would be duplicated if you would modify a configuration and save it.

@pivaldi
pivaldi commented Jul 18, 2011

Hi,

You're right, I had not thought about saving. What do you think about modifying getBlock and getParam instead ?
If so, what do you think about to add a parameter "raw" to these functions in order to provide an output without interference by the section "DEFAULT" ?

PS : sorry for my poor English, it's not my natural language.

@Ajnasz
Owner
@pivaldi
pivaldi commented Jul 20, 2011

What do you think?
I think that's good.
Take a look to my last commit.

@Ajnasz
Owner
@pivaldi
pivaldi commented Jul 21, 2011

Fixed :)

@Ajnasz Ajnasz merged commit 618816f into Ajnasz:master Jul 23, 2011
@Ajnasz
Owner
Ajnasz commented Jul 23, 2011

Merged your changes and also published to npm.

Thanks for the patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.