resource_uri is not resolved #1

Closed
Licenser opened this Issue Apr 6, 2012 · 5 comments

Comments

Projects
None yet
2 participants

Licenser commented Apr 6, 2012

Hi trying this out,
so the resource_uri is not resolved ending in failing to load.

Owner

AlainODea commented Apr 6, 2012

Hi Licenser:

I am going to take a look into this tonight. Hopefully I can push a bug fix for you soon :)

Best,
Alain

@AlainODea AlainODea closed this in 8eb4126 Apr 7, 2012

Owner

AlainODea commented Apr 7, 2012

Hi Licenser:

The bug you reported with failing to load Disqus threads due to a missing resource_uri should now be fixed.

Thank you again. Please report any other issues you encounter :)

Best,
Alain

AlainODea added a commit that referenced this issue Apr 7, 2012

Owner

AlainODea commented Apr 7, 2012

My original commit didn't truly fix this. Due to the way I was testing I again fell back on the mistake of checking threads that exist on Disqus already.

I originally fixed it by using id.uri in the template since I verified that it exists on each resource in Zotonic, but after checking the Zotonic documentation I changed that to id.resource_uri since uri is undocumented. I revisited my pages to see if Disqus still worked, which of course it did because the threads were already created. However, the original bug was not fixed since the disqus_url was blank. I am clearly too tired this evening :)

However, I am confident it is now fixed because I am now reviewing the generated HTML as well as the page behavior :)

Best,
Alain

@ghost ghost assigned AlainODea Apr 7, 2012

Licenser commented Apr 7, 2012

Thanks mate :)!

That is great!

Owner

AlainODea commented Apr 7, 2012

My pleasure Heinz :)

I'll be adding a THANKS file with your name in it later today. The mod was broken until you identified the source of the bug :)

Thank you,
Alain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment