New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README for RequestRetrier example #1794

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@pontus-andersson

pontus-andersson commented Nov 19, 2016

This PR fixes improves the README for the RequestRetrier. Some OAuth services returns a result that is not convertable to [String:String]. E.g. some services returns an expire timestamp as an integer:

{
	"token_type": "Bearer",
	"refresh_token": "******************************",
	"access_token": "******************************",
	"expires_in": 36000,
	"scope": "write read"
}

Copying the old example from the README would result in an unsuccessful result when refreshing the access token.

Pontus Andersson
Updated README for RequestRetrier example to cast result as [String:A…
…ny] to support more general oauth responses.
@cnoon

This comment has been minimized.

Show comment
Hide comment
@cnoon

cnoon Nov 20, 2016

Member

Good call @pontus-andersson! I made some small formatting tweaks to your PR and pushed them into master in ab0c767 while keeping your attribution.

Thanks again! 🍻

Member

cnoon commented Nov 20, 2016

Good call @pontus-andersson! I made some small formatting tweaks to your PR and pushed them into master in ab0c767 while keeping your attribution.

Thanks again! 🍻

@cnoon cnoon closed this Nov 20, 2016

@cnoon cnoon added the documentation label Nov 20, 2016

@cnoon cnoon added this to the 4.2.0 milestone Nov 20, 2016

@cnoon cnoon self-assigned this Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment