New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the request method to debugDescription. #1880

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jshier
Contributor

jshier commented Dec 29, 2016

This PR adds the request method to the DataResponse and DownloadResponse debugDescriptions.

@jshier jshier requested a review from cnoon Dec 29, 2016

@jshier jshier self-assigned this Dec 29, 2016

@cnoon

This comment has been minimized.

Show comment
Hide comment
@cnoon

cnoon Jan 14, 2017

Member

Looks good @jshier! I made a small tweak to this @jshier to fallback on GET rather than force unwrap the httpMethod. I pushed it up into master in 3f8575a.

Member

cnoon commented Jan 14, 2017

Looks good @jshier! I made a small tweak to this @jshier to fallback on GET rather than force unwrap the httpMethod. I pushed it up into master in 3f8575a.

@cnoon cnoon closed this Jan 14, 2017

@cnoon cnoon added the response label Jan 14, 2017

@cnoon cnoon added this to the 4.3.0 milestone Jan 14, 2017

@cnoon cnoon deleted the feature/method-in-debug-description branch Jan 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment