New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom string extension and use standard library equivalent in its place. #1994

merged 1 commit into from Apr 3, 2017


None yet
3 participants

Nirma commented Mar 1, 2017

The string extension defined in Tests/String+AlamofireTests.swift is redundant since the
Swift Standard Library provides String(repeating: count:) which accomplishes the same thing.


This comment has been minimized.

Show comment
Hide comment

jshier Apr 3, 2017


Thanks for the PR! A nice little change. Cheers! 🍻


jshier commented Apr 3, 2017

Thanks for the PR! A nice little change. Cheers! 🍻

@jshier jshier merged commit 1448562 into Alamofire:master Apr 3, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error

@cnoon cnoon added this to the 4.5.0 milestone Jun 16, 2017

@cnoon cnoon added the tests label Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment