New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs in examples #1997

Merged
merged 1 commit into from Apr 3, 2017

Conversation

Projects
None yet
3 participants
@reitzig
Contributor

reitzig commented Mar 1, 2017

URL.appendPathComponent is mutating; the example is set up to use the generating version URL.appendingPathComponent.

Fixes bugs in examples
`URL.appendPathComponent` is mutating; the example is set up to use the generating version `URL.appendingPathComponent`.
@jshier

This comment has been minimized.

Show comment
Hide comment
@jshier

jshier Apr 3, 2017

Contributor

Thanks for the PR! While this could just be a change to var, preserving let semantics is better. Cheers! 🍻

Contributor

jshier commented Apr 3, 2017

Thanks for the PR! While this could just be a change to var, preserving let semantics is better. Cheers! 🍻

@jshier jshier merged commit 89c0a76 into Alamofire:master Apr 3, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@reitzig reitzig deleted the reitzig:patch-2 branch Apr 3, 2017

@cnoon cnoon added the documentation label Jun 17, 2017

@cnoon cnoon added this to the 4.5.0 milestone Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment