New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use curl -v instead of curl -i in cURLRepresentation() #2070

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
2 participants
@webmaster128
Contributor

webmaster128 commented Apr 12, 2017

this prints header information to STDERR instead of STDOUT making it possible to process response body using pipes (e.g. decode gzip or apply JSON pretty print)

Use curl -v instead of curl -i in cURLRepresentation()
this prints header information to STDERR instead of STDOUT making it
possible to process response body using pipes (e.g. decode gzip or apply
JSON pretty print)
@webmaster128

This comment has been minimized.

Show comment
Hide comment
@webmaster128

webmaster128 Apr 25, 2017

Contributor

Fixed the tests for this update. Looks like the remaining fails are travis configuration issues

Contributor

webmaster128 commented Apr 25, 2017

Fixed the tests for this update. Looks like the remaining fails are travis configuration issues

@cnoon

This comment has been minimized.

Show comment
Hide comment
@cnoon

cnoon Jun 16, 2017

Member

Hi @webmaster128, thank you for putting this change together! 🍻

After some debate, we've decided to accept this PR and use curl -v moving forward. If anyone finds it to be a bit much, then you can always switch back to curl -i when pasting back into terminal.

Thanks again!

Member

cnoon commented Jun 16, 2017

Hi @webmaster128, thank you for putting this change together! 🍻

After some debate, we've decided to accept this PR and use curl -v moving forward. If anyone finds it to be a bit much, then you can always switch back to curl -i when pasting back into terminal.

Thanks again!

@cnoon

cnoon approved these changes Jun 16, 2017

@cnoon cnoon self-assigned this Jun 16, 2017

@cnoon cnoon added this to the 4.5.0 milestone Jun 16, 2017

@cnoon cnoon merged commit e1e8e62 into Alamofire:master Jun 16, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@webmaster128 webmaster128 deleted the webmaster128:curl-stderr branch Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment