New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift 4 Support #2163

Merged
merged 5 commits into from Jun 16, 2017

Conversation

Projects
None yet
2 participants
@jshier
Contributor

jshier commented Jun 16, 2017

This PR adds Swift 4 support by making Alamofire compatible with both Swift 3 and Swift 4. By default it builds using Swift 3, but in environments like CocoaPods or manual integration it can be built in Swift 4 as well.

This PR also refactors some testing issues and enables background session tests, which seem to be the only place those tests work.

@jshier jshier requested a review from cnoon Jun 16, 2017

@cnoon

Looks good overall @jshier...just a few formatting comments. Nothing major. 👍🏼

Show outdated Hide outdated Source/ParameterEncoding.swift
Show outdated Hide outdated Source/SessionManager.swift
Show outdated Hide outdated Tests/ResponseTests.swift
Show outdated Hide outdated Tests/ResponseTests.swift
Show outdated Hide outdated Tests/SessionManagerTests.swift
Show outdated Hide outdated Tests/SessionManagerTests.swift
@@ -92,15 +92,15 @@ class ProxyURLProtocol: URLProtocol {
// MARK: -
extension ProxyURLProtocol: URLSessionDelegate {
extension ProxyURLProtocol: URLSessionDataDelegate {

This comment has been minimized.

@cnoon

cnoon Jun 16, 2017

Member

Nice catch!

@cnoon

cnoon Jun 16, 2017

Member

Nice catch!

Show outdated Hide outdated Tests/UploadTests.swift
Show outdated Hide outdated Tests/UploadTests.swift
@cnoon

cnoon approved these changes Jun 16, 2017

Looks good @jshier! 👍🏼

@cnoon cnoon merged commit 8e85284 into master Jun 16, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cnoon cnoon deleted the xcode9 branch Jun 16, 2017

@cnoon cnoon self-assigned this Jun 17, 2017

@cnoon cnoon added this to the 4.5.0 milestone Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment