New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @discardableResult #2338

merged 1 commit into from Oct 30, 2017


None yet
2 participants

rastersize commented Oct 24, 2017

Goals ⚽️

  • Align request(_:) with the other methods.

Implementation Details 🚧

All the other request, download, upload and so on methods are annotated with @discardableResult. This changes makes sure that method can be used for fire-and-forget calls.


This comment has been minimized.

Show comment
Hide comment

jshier Oct 30, 2017


Thanks for the PR! Cheers! 🍻


jshier commented Oct 30, 2017

Thanks for the PR! Cheers! 🍻

@jshier jshier merged commit c4b4bb4 into Alamofire:master Oct 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@jshier jshier added this to the 4.6.0 milestone Dec 4, 2017

@rastersize rastersize deleted the rastersize:patch-1 branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment