Add missing @discardableResult

[rastersize]

Goals ⚽

• Align request(_:) with the other methods.

Implementation Details 🚧

All the other request, download, upload and so on methods are annotated with @discardableResult. This changes makes sure that method can be used for fire-and-forget calls.

[jshier]

Thanks for the PR! Cheers! 🍻

[jpdutoit]

Should this be reverted in the latest version? It looks like the request is being released automatically if no response handler is added...

[jshier]

We probably should, but it would need a major version revision. We'll have to see how the next version's APIs shake out and reevaluate.

[jpdutoit]

Ok. In our case this caused a bunch of problems when our fire-and-forget API calls stopped firing after updating Alamofire.

[jshier]

To be clear, that behavioral change is intentional, as Requests no longer start until a response handler has been added or resume() has been called. That's true whether or not the instance is retained.

[jpdutoit]

Thanks for the clarification. I must have missed it in the release notes