New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error mapping functions to Response types #2361

Merged
merged 8 commits into from Nov 27, 2017

Conversation

Projects
None yet
1 participant
@jshier
Contributor

jshier commented Nov 20, 2017

Issue Link 馃敆

#2306

Goals 鈿斤笍

This PR adds mapError and flatMapError to DataResponse and DownloadResponse.

Implementation Details 馃毀

Nothing special, just a straightforward porting of the functionality, similar to the previous map and flatMap

Testing Details 馃攳

Tests added for the additional API.

@jshier jshier changed the title from Functional api sync to Add Error mapping functions to Response types Nov 20, 2017

@jshier jshier changed the base branch from master to readme-refactor Nov 20, 2017

@jshier jshier changed the base branch from readme-refactor to master Nov 20, 2017

@jshier jshier changed the base branch from master to alamofire5 Nov 27, 2017

@jshier jshier changed the base branch from alamofire5 to master Nov 27, 2017

@jshier jshier merged commit 0a34b44 into master Nov 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jshier jshier deleted the functional-api-sync branch Nov 27, 2017

@jshier jshier added this to the 4.6.0 milestone Dec 4, 2017

@groue groue referenced this pull request Dec 21, 2017

Closed

Completing #2135 #2306

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment