New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify OS versions affected by download resume bug #2389

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
2 participants
@getaaron
Contributor

getaaron commented Dec 18, 2017

The bug referenced in Usage.md was fixed in iOS 10.2, etc. This PR updates the documentation which still erroneously refers to these as the "latest" release.

@jshier

This comment has been minimized.

Contributor

jshier commented Dec 21, 2017

Thanks for the PR, this is great info! One minor nit, please add spaces around the hyphens. Once that's done we can merge.

@getaaron

This comment has been minimized.

Contributor

getaaron commented Dec 21, 2017

Hi @jshier, to be extra nit picky, those are not hyphens, but en dashes, which typically are not surrounded by spaces when expressing a numeric range. See, for example, http://www.thepunctuationguide.com/en-dash.html

@jshier jshier changed the base branch from master to clarify-os-bug-versions Feb 18, 2018

@jshier jshier merged commit 9c9e6f6 into Alamofire:clarify-os-bug-versions Feb 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier referenced this pull request Feb 18, 2018

Merged

Update to #2389 #2443

jshier added a commit that referenced this pull request Feb 18, 2018

Update to #2389 (#2443)
* Clarify OS versions affected by download resume bug (#2389)

* Rephrase a bit.

@jshier jshier added this to the 4.7.0 milestone Feb 18, 2018

jshier added a commit that referenced this pull request Mar 5, 2018

Update to #2389 (#2443)
* Clarify OS versions affected by download resume bug (#2389)

* Rephrase a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment