Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Removes the old request to avoid endless growth. #2412
Remove the old request from delegate.protectedRequests before assigning new one.
Do you have a rough timescale for when this PR might be merged? We have unfortunately been hit by this problem, and it is causing unbounded memory growth when there are lots of retried requests (e.g. on poor quality mobile connections). We can patch locally, but it would be great to see the fix in an official release.
(Thank you for making Alamofire - it's awesome!).
@jshier this is absolutely something we need to get resolved ASAP. I'd recommend we move this through on this branch, then cherry pick the change back to
There's quite a few ways we could test this, but it will require a retrier to keep retrying (maybe up to say 2 or 3 times), and then stop retrying. Then we just need to run a count on the session delegate's number of requests.