New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultTests: Small updates and typos fix #2416

Merged
merged 2 commits into from Feb 18, 2018

Conversation

Projects
None yet
2 participants
@alaphao
Contributor

alaphao commented Jan 21, 2018

Goals ⚽️

Update ResultTests by:

  • Fixing typos in unit tests failure messages
  • Removing String.character.count warnings
  • Using XCTAssertNil and XCTAssertNotNil for nil assertion
ResultTests: Update and fix typos
Using String.count instead of String.characters.count
Fix typos in some test failure messages
Asserting nil and not nil with XCTAssertNil and XCTAssertNotNil

@jshier jshier changed the base branch from alamofire5 to master Feb 18, 2018

@jshier jshier added this to the 4.7.0 milestone Feb 18, 2018

@jshier

This comment has been minimized.

Contributor

jshier commented Feb 18, 2018

We can probably get this into 4.7.0, as long as it doesn't conflict with my changes.

@jshier jshier merged commit abf2fb7 into Alamofire:master Feb 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

jshier added a commit that referenced this pull request Mar 5, 2018

ResultTests: Update and fix typos (#2416)
Using String.count instead of String.characters.count
Fix typos in some test failure messages
Asserting nil and not nil with XCTAssertNil and XCTAssertNotNil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment