Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding RetryPolicy Logic #2713

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@cnoon
Copy link
Member

cnoon commented Feb 9, 2019

This is a simple PR that moves the retry implementation for the RequestRetrier conformance on RetryPolicy into the actual class and out of the extension. The reason for this is to allow subclasses to override the method. If the method is implemented in an extension, it cannot be overridden even though it is open. This PR fixes the issue.

Goals ⚽️

To allow RetryPolicy subclasses to override the retry API if necessary.

Testing Details 🔍

No tests are necessary for this change.

@cnoon cnoon requested a review from jshier Feb 9, 2019

@cnoon cnoon self-assigned this Feb 9, 2019

@cnoon cnoon added this to the 5.X milestone Feb 9, 2019

@cnoon cnoon added the retry policy label Feb 9, 2019

@jshier

jshier approved these changes Feb 13, 2019

Copy link
Contributor

jshier left a comment

👍

@cnoon cnoon merged commit 5ff0c8a into master Feb 15, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@cnoon cnoon deleted the feature/overriding-retry-logic branch Feb 15, 2019

@jshier jshier modified the milestones: 5.X, 5.0.0-beta.3 Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.