Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when casting to *Response<Any> #2740

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
1 participant
@jshier
Copy link
Contributor

jshier commented Mar 7, 2019

Goals ⚽️

This PR fixes a crash that occurs when using the ClosureEventMonitor's requestDidParseAnyResponse closure, as casting from a generic *Response<Value> to *Response<Any> does not work.

Implementation Details 🚧

This PR just removes the offending methods. Since there's no way to express generic closures we may not be able to support these events in ClosureEventMonitor.

Testing Details 🔍

EventMonitor currently has no tests, but adding them is left for the future.

@jshier jshier merged commit ef3512f into master Mar 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jshier jshier deleted the bug/crashing-serialization-event branch Mar 7, 2019

@jshier jshier modified the milestones: 5.X, 5.0.0-beta.3 Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.