Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Support for swift package manager 5 in Alamofire 4.8.x #2762

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@klaas
Copy link

commented Mar 26, 2019

Currently Alamofire 4.8.1 does not compile with Apple Swift version 5.0 (swiftlang-1001.0.69.5 clang-1001.0.46.3) on macOS 10.14.4.

Error: cannot convert value of type 'Int' to expected element type 'SwiftVersion'

This new Package.swift works with Apple Swift Package Manager - Swift 4.2.0 (swiftpm-14460.2) and Apple Swift Package Manager - Swift 5.0.0 (swiftpm-14490.60.2).

@cnoon cnoon requested a review from jshier Mar 26, 2019

@jshier

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Looks good, thanks!

@jshier jshier merged commit 2ab1257 into Alamofire:hotfix Mar 26, 2019

@jshier jshier added this to the 4.8.2 milestone Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.