Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Switches and Queues #2765



None yet
3 participants
Copy link

commented Mar 26, 2019

This PR is a simplification of #2691 where some of the changes have been culled out due to either being changes we do not agree with, or changes that were incorrect.

Issue Link 馃敆

This is a subset of #2691 that maintains attribution to @jdisho.

Goals 鈿斤笍

To refactor the switches into guards where applicable and also move away from optional queues in the response serialization logic.

Implementation Details 馃毀

No real details here worth calling out other than this PR is piggy-backed on #2716 since that PR contains a lot of changes with regards to the DispatchQueue usage in response serialization.

Testing Details 馃攳

Test suite still looks good. These changes do not change any actual functionality.

@cnoon cnoon added the swift label Mar 26, 2019

@cnoon cnoon added this to the 5.0.0-beta.4 milestone Mar 26, 2019

@cnoon cnoon self-assigned this Mar 26, 2019

@cnoon cnoon requested a review from jshier Mar 26, 2019

@cnoon cnoon referenced this pull request Mar 26, 2019


Simplify and refactor #2691

@cnoon cnoon added the enhancement label Mar 26, 2019


jshier approved these changes Mar 27, 2019

Copy link

left a comment

One minor change, but otherwise looks good.

Show resolved Hide resolved Source/ParameterEncoding.swift Outdated

@cnoon cnoon force-pushed the refactor/switches-and-queues branch from cf34434 to 9ea95f6 Mar 27, 2019

@cnoon cnoon merged commit b3e5d26 into feature/response-serializer-retry-support Mar 27, 2019

@cnoon cnoon deleted the refactor/switches-and-queues branch Mar 27, 2019

cnoon added a commit that referenced this pull request Mar 27, 2019

@cnoon cnoon changed the title 馃惙 Refactor - Switches and Queues Refactor - Switches and Queues Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.