Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Condensing MultipartFormData Data APIs #2766

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@cnoon
Copy link
Member

commented Mar 27, 2019

This PR is a small modification from #2718 while maintaining attribution to @rivera-ernesto. It combines the data APIs in MultipartFormData into a single API.

Issue Link 馃敆

This issue drops a couple of the changes in #2718 while maintaining attribution.

Goals 鈿斤笍

Squash the duplicate MultipartFormData APIs where applicable.

Implementation Details 馃毀

No functional changes, just using optionals and default arguments where applicable.

Testing Details 馃攳

Test suite is still passing.

@cnoon cnoon added this to the 5.0.0-beta.4 milestone Mar 27, 2019

@cnoon cnoon self-assigned this Mar 27, 2019

@cnoon cnoon requested a review from jshier Mar 27, 2019

@jshier

jshier approved these changes Mar 27, 2019

Copy link
Contributor

left a comment

馃憤 Great simplification!

@cnoon cnoon merged commit 0998c25 into master Mar 27, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@cnoon cnoon deleted the refactor/condensing-multipart-form-data-apis branch Mar 27, 2019

cnoon added a commit that referenced this pull request Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.