Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5!!! #2771

Merged
merged 3 commits into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@cnoon
Copy link
Member

commented Mar 27, 2019

This PR updates the two Xcode projects, source code, test code, SPM package, and podspec to Swift 5. I have a little demo using SPM verifying things are working, so we should be good on that front.

Goals ⚽️

Move the entire project onto Xcode 10.2 and Swift 5 only.

Implementation Details 🚧

Migrator and package verification.

Testing Details 🔍

Just requires the test suite to pass. No new tests are needed. I had to fix up some user agent tests and encoder tests where the key-value pairs were no longer sorted.

@cnoon cnoon self-assigned this Mar 27, 2019

@cnoon cnoon requested a review from jshier Mar 27, 2019

@cnoon cnoon added this to the 5.0.0-beta.4 milestone Mar 27, 2019

@cnoon

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Just realized I missed the travis updates. Will fix.

@@ -780,3 +780,10 @@ private struct FailingOptionalStruct: Encodable {
}
}
}

private func XCTAssertQueryEqual(_ query1: String?, _ query2: String?) {

This comment has been minimized.

Copy link
@jshier

jshier Mar 27, 2019

Contributor

Nice!

@jshier

jshier approved these changes Mar 27, 2019

Copy link
Contributor

left a comment

👍

@jshier jshier merged commit 050f4e0 into master Mar 27, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier deleted the swift5 branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.