Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFResult #2774

Merged
merged 5 commits into from Mar 29, 2019

Conversation

Projects
None yet
4 participants
@cnoon
Copy link
Member

commented Mar 28, 2019

This PR is a combination of #2769 from @AtomicCat and the changes in db8b231 from @ejensen with changes from myself with what should be exposed.

Issue Link 馃敆

#2752

Goals 鈿斤笍

There are a few:

  • Replace the Alamofire.Result type with the Foundation.Result type build by our own @jshier!
  • Remove any public extension APIs that duplicate the new Foundation.Result APIs.

Implementation Details 馃毀

The main details of this implementation are described in-depth in #2752.

Testing Details 馃攳

The test suite has been updated accordingly.

NOTE: I'll swing back here and add more detail to this PR shortly. have to run to a meeting

@cnoon cnoon added the result label Mar 28, 2019

@cnoon cnoon added this to the 5.0.0-beta.4 milestone Mar 28, 2019

@cnoon cnoon self-assigned this Mar 28, 2019

@cnoon cnoon requested a review from jshier Mar 28, 2019

@cnoon cnoon changed the title AFResult Typealias AFResult Mar 28, 2019

@jshier
Copy link
Contributor

left a comment

I think we need to be a bit more consistent about what we offer namespaced vs. not and public vs. not. If it's namespaced, it should be public, if we don't want it public, we should just make it part of the internal extension.

Show resolved Hide resolved Source/Request.swift
Show resolved Hide resolved Source/AFResult.swift Outdated
Show resolved Hide resolved Source/Response.swift Outdated
@ejensen
Copy link
Contributor

left a comment

A couple minor comments. Overall, lookin' good!

Show resolved Hide resolved Source/AFResult.swift Outdated
Show resolved Hide resolved Tests/AFResultTests.swift Outdated
@jshier

jshier approved these changes Mar 29, 2019

Copy link
Contributor

left a comment

Just some minor extension issues, but otherwise looks good to go!

Show resolved Hide resolved Source/AFResult.swift Outdated
Show resolved Hide resolved Source/AFResult.swift
Show resolved Hide resolved Tests/AFResult+Alamofire.swift Outdated

@cnoon cnoon referenced this pull request Mar 29, 2019

Closed

Feature/swift result #2769

@cnoon cnoon merged commit 38e19b1 into master Mar 29, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cnoon cnoon deleted the afresult-typealias branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.