Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - SessionStateProvider ACL #2801

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@cnoon
Copy link
Member

commented Apr 12, 2019

This PR moves the SessionStateProvider to an internal type since it's not intended to be public. It also renames the file to SessionDelegate.swift.

Goals ⚽️

Keep all internal API internal!

Implementation Details 🚧

N/A

Testing Details 🔍

N/A

@cnoon cnoon added this to the 5.0.0-beta.5 milestone Apr 12, 2019

@cnoon cnoon requested a review from jshier Apr 12, 2019

@cnoon cnoon self-assigned this Apr 12, 2019

@jshier

jshier approved these changes Apr 12, 2019

Copy link
Contributor

left a comment

👍

@cnoon cnoon merged commit d24da77 into master Apr 12, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@cnoon cnoon deleted the audit/session-state-provider branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.