Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - HTTP Headers Refactor #2802

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@cnoon
Copy link
Member

commented Apr 12, 2019

This PR refactors the HTTPHeader and HTTPHeaders types to Header and Headers.

Goals ⚽️

The goal of this PR is to drop the unnecessary HTTP prefix as well as simplify the property extensions on system types. Properties with http in the name are the Apple variants, where ones without are the Alamofire variants.

Implementation Details 🚧

Pretty straightforward, just refactored throughout the codebase.

Testing Details 🔍

N/A

@cnoon cnoon added the http headers label Apr 12, 2019

@cnoon cnoon added this to the 5.0.0-beta.5 milestone Apr 12, 2019

@cnoon cnoon requested a review from jshier Apr 12, 2019

@cnoon cnoon self-assigned this Apr 12, 2019

@jshier jshier force-pushed the audit/http-headers branch from 035db44 to 3bfd129 Apr 13, 2019

@jshier

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

I've updated the PR for only the httpHeaders to headers property rename. The type name remains the same.

@cnoon
Copy link
Member Author

left a comment

👍🏻

@cnoon cnoon merged commit 9d1cec8 into master Apr 13, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cnoon cnoon deleted the audit/http-headers branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.