Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - Notification Names #2803

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@cnoon
Copy link
Member

cnoon commented Apr 12, 2019

This PR adds a Notification suffix to the Request notification names to make the API more clear. It also adds notification support for task events.

Goals ⚽️

To make the notification names more clear and add notification support for task events.

Implementation Details 🚧

Refactored the property names and added new ones for the task events.

Testing Details 🔍

Updated the tests to also check for task notifications.

@cnoon cnoon added the request label Apr 12, 2019

@cnoon cnoon added this to the 5.0.0-beta.5 milestone Apr 12, 2019

@cnoon cnoon requested a review from jshier Apr 12, 2019

@cnoon cnoon self-assigned this Apr 12, 2019

@jshier

jshier approved these changes Apr 12, 2019

Copy link
Contributor

jshier left a comment

👍, just one minor naming nit.

Show resolved Hide resolved Source/Notifications.swift Outdated

@cnoon cnoon merged commit 2346c56 into master Apr 12, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cnoon cnoon deleted the audit/notification-names branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.