Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - MultipartUpload ACL #2805

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@cnoon
Copy link
Member

commented Apr 12, 2019

This PR changes the MultipartUpload ACL from public to internal and moves the encodingMemoryThreshold into MultipartFormData.

Goals ⚽️

To make MultipartUpload an internal type since it is an internal upload implementation detail.

Implementation Details 🚧

The MultipartUpload type should be an internal type that pulls MultipartFormData creation and encoding into a single location. This is pure AF implementation and isn't necessary to vend publicly. Therefore, this PR moves it to be an internal type.

The other required change is to then find a new home for encodingMemoryThreshold. It didn't make sense to me to make an entire type public just to expose a static property on it. It also conforms to multiple protocols so that conforms also then needed to be public. The two logic places to hang the API publicly are UploadRequest and MultipartFormData. I chose MultipartFormData for this PR, but I could easily see UploadRequest being a descent fit as well.

Testing Details 🔍

N/A

@cnoon cnoon added this to the 5.0.0-beta.5 milestone Apr 12, 2019

@cnoon cnoon requested a review from jshier Apr 12, 2019

@cnoon cnoon self-assigned this Apr 12, 2019

@jshier

jshier approved these changes Apr 12, 2019

Copy link
Contributor

left a comment

👍 , pending final on MultipartUpload.

@cnoon cnoon merged commit 9361fd2 into master Apr 12, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cnoon cnoon deleted the audit/multipart-upload branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.