Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not create resume data on cancel for DownloadRequest #2851

Merged

Conversation

@ullstrm
Copy link

commented Jun 20, 2019

Issue Link 馃敆

#2841

Goals 鈿斤笍

Add option to not create resume data on cancel for DownloadRequest. I've noticed that in Alamofire 5 this has now become the default behaviour of the cancel for DownloadRequest. It would be great to at least add this possibility to Alamofire 4.

Implementation Details 馃毀

An assumption is made that there is no problem to just leave the resumeData-property of the downloadDelegate as-is.

Testing Details 馃攳

I've added a test that verifies that this function is not adding any resume data.

@ullstrm ullstrm force-pushed the ullstrm:feature/cancel-without-resume-data branch from 58f9b6b to 8e654d3 Jun 20, 2019

@BinaryDennis

This comment has been minimized.

Copy link

commented Jun 27, 2019

This PR looks good to me 馃憤
Would be nice if it got merged soon

@danielsaidi

This comment has been minimized.

Copy link

commented Aug 7, 2019

Yes, we need this in the main repo!

@jshier jshier added this to the 4.9.0 milestone Sep 3, 2019

@jshier
jshier approved these changes Sep 3, 2019
Copy link
Contributor

left a comment

馃憤

@jshier

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Thanks for the PR!

@jshier jshier merged commit a54d935 into Alamofire:hotfix Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.