Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataEncoding and KeyEncoding. #2858

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@jshier
Copy link
Contributor

commented Jun 30, 2019

Issue Link 馃敆

#2849

Goals 鈿斤笍

This PR adds KeyEncoding and DataEncoding types to URLEncodedFormEncoder and pulls the encoder into its own file.

Implementation Details 馃毀

Implementation details for the DataEncoding and KeyEncoding types come from Swift JSONEncoder and XMLEncoder.

Testing Details 馃攳

Tests added for the new key encodings and data encodings.

@cnoon

cnoon approved these changes Jul 8, 2019

Copy link
Member

left a comment

Looks good to me @jshier. I didn't dig through all the functionality super in-depth given the diff being a full removal and addition. But everything looks good overall. Let me know if there's anything you'd like me to review or need specific feedback on.

@jshier

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@cnoon The logic is copied from XMLCoder and JSONEncoder, so I think we're good.

@jshier jshier merged commit 7c743e5 into master Jul 8, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier deleted the feature/enhanced-form-encoder branch Jul 8, 2019

jshier added a commit that referenced this pull request Jul 10, 2019

jshier added a commit that referenced this pull request Jul 15, 2019

Update cURL support for async request creation. (#2863)
* Connect events to cURL description.

* Clean up and add more tests.

* Add DataEncoding and KeyEncoding. (#2858)

* Appending response serializer now resumes request if finished to handle races (#2862)

jshier added a commit that referenced this pull request Jul 19, 2019

jshier added a commit that referenced this pull request Jul 19, 2019

Update cURL support for async request creation. (#2863)
* Connect events to cURL description.

* Clean up and add more tests.

* Add DataEncoding and KeyEncoding. (#2858)

* Appending response serializer now resumes request if finished to handle races (#2862)

toomasr added a commit to toomasr/Alamofire that referenced this pull request Aug 19, 2019

toomasr added a commit to toomasr/Alamofire that referenced this pull request Aug 19, 2019

Update cURL support for async request creation. (Alamofire#2863)
* Connect events to cURL description.

* Clean up and add more tests.

* Add DataEncoding and KeyEncoding. (Alamofire#2858)

* Appending response serializer now resumes request if finished to handle races (Alamofire#2862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.