Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FileManager to be passed to UploadRequest. #2898

Merged
merged 2 commits into from Aug 11, 2019

Conversation

@jshier
Copy link
Contributor

commented Aug 9, 2019

Goals ⚽️

This PR adds the final FileManager abstraction for Alamofire 5, allowing an instance to be passed to UploadRequests to be used for final disk cleanup.

Implementation Details 🚧

This is largely an API change that allows the FileManager to be passed in. I also took the opportunity to tweak the multipart form data APIs so that the defaulted threshold parameter comes after the non-defaulted parameters, as it recommended.

Testing Details 🔍

No tests added.

@jshier jshier requested a review from cnoon Aug 9, 2019

@jshier jshier added this to the 5.0.0.rc.1 milestone Aug 9, 2019

@cnoon
cnoon approved these changes Aug 9, 2019
Copy link
Member

left a comment

Looks good @jshier! 🍻

@jshier jshier merged commit 31d8afd into master Aug 11, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier deleted the feature/upload-filemanager branch Aug 11, 2019

toomasr added a commit to toomasr/Alamofire that referenced this pull request Aug 19, 2019
Allow FileManager to be passed to UploadRequest. (Alamofire#2898)
* Allow FileManager to be passed to UploadRequest.

* Fix some spelling and inline doc alignment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.