Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Alamofire Can't Be Used With Background Sessions #2917

Merged
merged 5 commits into from Aug 29, 2019

Conversation

@jshier
Copy link
Contributor

commented Aug 25, 2019

Goals ⚽️

This PR adds explicit preconditions to the Session initializers to ensure Alamofire isn't used with background sessions, in order to prevent ongoing issues around support and surprise on the part of the user.

Implementation Details 🚧

Simply adds precondition calls which check for the URLSessionConfiguration.identifier, which is only set when configured for background sessions.

Testing Details 🔍

Tests using background sessions have been disabled.

@jshier jshier requested a review from cnoon Aug 25, 2019

@jshier jshier added this to the 5.0.0.rc.1 milestone Aug 25, 2019

jshier added 4 commits Aug 28, 2019
@cnoon
cnoon approved these changes Aug 29, 2019
Copy link
Member

left a comment

Looks good to me @jshier. 👌🏻

@jshier jshier merged commit 1d5411c into master Aug 29, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier deleted the feature/background-session-precondition branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.