Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bundle id per platform #2928

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@JonMo
Copy link
Contributor

commented Sep 3, 2019

Issue Link 馃敆

#2925

Goals 鈿斤笍

Fixing an issue when submitting a binary to the App Store:
ITMS-90806: CFBundleIdentifier collision - Each bundle must have a unique bundle identifier. The bundle identifier 'org.cocoapods.Alamofire' is used in the bundles '[Alamofire.framework, Alamofire.framework]'

Implementation Details 馃毀

Add platform name to Project bundle identifier

@jshier

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Thanks for the PR! This looks good to me, we just need to make sure there're no unintended consequences.

@cnoon Any comment?

@jshier

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@JonMo Also, could you open another version of this PR against the hotfix branch so we can release it for v4 as well?

@cnoon
cnoon approved these changes Sep 3, 2019
Copy link
Member

left a comment

Looks good to me! We'll need to make the same change on AFI as well I believe.

@jshier jshier added this to the 5.0.0.rc.1 milestone Sep 3, 2019

@jshier jshier merged commit dd53320 into Alamofire:master Sep 3, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@JonMo JonMo referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.