Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bundle id per platform #2930

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@JonMo
Copy link
Contributor

commented Sep 3, 2019

Issue Link 馃敆

#2925 and PR #2928

Goals 鈿斤笍

Fixing an issue when submitting a binary to the App Store:
ITMS-90806: CFBundleIdentifier collision - Each bundle must have a unique bundle identifier. The bundle identifier 'org.cocoapods.Alamofire' is used in the bundles '[Alamofire.framework, Alamofire.framework]'

Implementation Details 馃毀

Add platform name to Project bundle identifier. Remove the bundle identifier for each target - so it is referenced to the Main project bundle id.

@JonMo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@jshier Here is the PR regarding the discussion on #2928

@jshier

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Looks good, thanks! I'll merge this for the 4.9 release.

@jshier jshier added this to the 4.9.0 milestone Sep 3, 2019

@jshier
jshier approved these changes Sep 3, 2019
Copy link
Contributor

left a comment

馃憤

@jshier jshier merged commit cc4fdf0 into Alamofire:hotfix Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.