Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reachability behavior regression from 4.8.1. #2931

Merged
merged 10 commits into from Sep 4, 2019

Conversation

@jshier
Copy link
Contributor

commented Sep 3, 2019

Issue Link 馃敆

#2731

Goals 鈿斤笍

This PR fixes a regression from 4.8.1 that prevented stopped and started reachability managers from sending an initial listener callback.

Implementation Details 馃毀

This PR restores a previous state reset to ensure the listener callback will be fired.

Testing Details 馃攳

Added a test for the start / stop / start behavior to ensure we get the appropriate callbacks.

@cnoon
cnoon approved these changes Sep 3, 2019
Copy link
Member

left a comment

Looks good @jshier! 馃憤馃徎

@jshier jshier merged commit 736fe64 into hotfix Sep 4, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier deleted the bugfix/v4-reachability-state-regression branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.