Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-generic Error usage in RC1 #2937

Merged
merged 3 commits into from Sep 8, 2019

Conversation

@jshier
Copy link
Contributor

commented Sep 6, 2019

Goals ⚽️

This PR fixes a missed non-generic Error case in the Response transform APIs that prevents proper transform of the error type.

Implementation Details 🚧

Error -> Failure

Also enabled Zombies for testing to see if we can track down the occasional crash in the transform tests.

Testing Details 🔍

Updated test error transforms to use AFError.

@cnoon
cnoon approved these changes Sep 6, 2019
Copy link
Member

left a comment

Looks good @jshier!

@jshier jshier merged commit 1846ee6 into master Sep 8, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jshier jshier deleted the bugfix/non-generic-error branch Sep 8, 2019

@jshier jshier added this to the 5.0.0-rc.2 milestone Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.