Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SecTrust Catalyst Deprecation Warning - Alamofire 4 #2979

Merged
merged 2 commits into from Oct 21, 2019

Conversation

@jshier
Copy link
Contributor

jshier commented Oct 21, 2019

Goals ⚽️

This PR matches the functional change in #2977 but simplified, since Alamofire 4 doesn't preserve any error information for trust failures.

Implementation Details 🚧

ThisPR simply replaces the old logic with the new call.

This PR also adopts GitHub Actions for CI on the hotfix branch.

Testing Details 🔍

Tests passed without updates, as this check doesn't bubble up to the errors reported, unlike in version 5.

jshier added 2 commits Oct 21, 2019
@cnoon
cnoon approved these changes Oct 21, 2019
Copy link
Member

cnoon left a comment

Looks good @jshier.

@jshier jshier merged commit 4f53c3a into hotfix Oct 21, 2019
5 checks passed
5 checks passed
Test macOS
Details
Test iOS (OS=13.1,name=iPhone 11 Pro)
Details
Test tvOS (OS=13.0,name=Apple TV 4K)
Details
Build watchOS (OS=6.0,name=Apple Watch Series 5 - 44mm)
Details
Test SPM Integration
Details
@jshier jshier deleted the bug/v4-catalyst-warnings branch Oct 21, 2019
@jshier jshier added this to the 4.9.1 milestone Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.