Test Refactor with Firewalk #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshier
force-pushed
the
update/test-cleanup
branch
from
53d1f5d
to
42188d9
Compare
jshier
force-pushed
the
update/test-cleanup
branch
from
d476965
to
691d346
Compare
jshier
force-pushed
the
update/test-cleanup
branch
from
691d346
to
8629ccb
Compare
jshier
force-pushed
the
update/test-cleanup
branch
from
2e6d48b
to
df57361
Compare
jshier
force-pushed
the
update/test-cleanup
branch
from
df57361
to
eaf6e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR attempts to fix our ongoing test reliability issues by replacing direct calls to httpbin.org with a local instance of Firewalk.
Implementation Details 🚧
This PR abstracts all test
URLs andURLRequests into theEndpointtype, which has convenience methods for all of the various test paths. It also includesSessionextensions to make usingEndpointmuch nicer, allowing the replacement ofrequest(URLRequest.makeHTTPBinRequest())withrequest(.default)orrequest(.delay(1)). This should allow us to more easily add reusable testing endpoints in the future.Testing Details 🔍
Reenables the redirect tests and adds a test for 307 redirect handling (using a new Firewalk feature that goes beyond HTTPBin). Otherwise it's a large test refactor to use the new
Endpointtype.