Require Swift 5.3 #3495
Merged
Require Swift 5.3 #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegocesarmoura
approved these changes
Sep 18, 2021
jshier
force-pushed
the
update/require-swift-5.3
branch
from
8e87454
to
93f3053
Compare
jshier
added a commit
that referenced
this pull request
Jan 15, 2022
* Update to Swift 5.3. * Use correct target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR bumps Alamofire's required Swift version to 5.3 / Xcode 12 now that Xcode 13 is imminent. Since no one can release software on iOS with older Xcode versions, it seems safe to drop this. Older macOS users can keep using older Alamofire versions.
This also follows SwiftNIO's Swift version support which they recently updated. However, instead of tracking Swift prerelease - 2, we'll track Swift current - 2. So with 5.5 out we'll go back to 5.3 and with 5.6 we may update to 5.4, but that isn't necessarily guaranteed.
Implementation Details 🚧
SwiftFormat has been set to 5.3 mode and run. Updates are entirely closure to key path conversion.