Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation regarding contributions #3500

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

TiagoMaiaL
Copy link
Contributor

Issue Link 🔗

https://forums.swift.org/t/broken-unit-tests-for-the-ios-scheme/52371/5

Goals ⚽

  • Document how to contribute to the project by sending pull requests.
  • Document how to configure the automated tests to be run.

Implementation Details 🚧

I've changed the CONTRIBUTING.md file, adding a section about pull requests. I've also linked it from the project README.md.

Copy link
Contributor

@jshier jshier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some phrasing suggestions. Thanks for this!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TiagoMaiaL TiagoMaiaL requested a review from jshier October 3, 2021 13:53
@TiagoMaiaL
Copy link
Contributor Author

TiagoMaiaL commented Oct 3, 2021

Thanks for the corrections and Improvements. I just applied them.

Copy link
Contributor

@jshier jshier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jshier jshier merged commit c8f5add into Alamofire:master Oct 4, 2021
@jshier jshier added this to the 5.5.0 milestone Dec 13, 2021
jshier pushed a commit that referenced this pull request Jan 15, 2022
* Document how to contribute with code

* Improve the contribution guides according to code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants